Home
Exceptions should not be ignored
Rule description
- Exceptions should not be ignored
Non-compliant Code Example
DECLARE errorLog_ EXCEPTION; BEGIN FOR i IN 1 .. CUSTOMER_TABLE.COUNT LOOP IF CUSTOMER_TABLE(i) IS NOT NULL THEN DBMS_OUTPUT.PUT( i || ' = (' || CUSTOMER_TABLE(i).Name || ', ' || CUSTOMER_TABLE(i).PhoneNumber || ')' ); END IF; END LOOP; EXCEPTION WHEN ERRORS THEN RETURN; --Non compliant code (Exception is ignored by simply returning) END CUSTOMER_TABLE_ITERATION;
Compliant Code Example
BEGIN FOR i IN 1 .. CUSTOMER_TABLE.COUNT LOOP IF CUSTOMER_TABLE(i) IS NOT NULL THEN DBMS_OUTPUT.PUT( i || ' = (' || CUSTOMER_TABLE(i).Name || ', ' || CUSTOMER_TABLE(i).PhoneNumber || ')' ); END IF; END LOOP; EXCEPTION WHEN ERRORS THEN Log_Errors ( 'Error Log...' || Chr(10) || DBMS_UTILITY.FORMAT_ERROR_STACK() ); Log_Errors ( 'Error Log...' || Chr(10) || DBMS_UTILITY.FORMAT_ERROR_BACKTRACE() ); DBMS_OUTPUT.PUT_LINE ( '----------' ); RAISE; --Compliant code (Process error properly) END CUSTOMER_TABLE_ITERATION;