Home

CASE expressions should not have too many WHEN clauses

Rule description

  • CASE expressions should not have too many WHEN clauses

 

Non-compliant Code Example

SELECT 
CASE
    WHEN UnitsInStock < 10 THEN 'The quantity is less than 10' 
    WHEN UnitsInStock < 20 THEN 'The quantity is less than 20' 
    WHEN UnitsInStock < 30 THEN 'The quantity is less than 30' 
    WHEN UnitsInStock < 40 THEN 'The quantity is less than 40' 
    WHEN UnitsInStock < 50 THEN 'The quantity is less than 50' 
    WHEN UnitsInStock < 60 THEN 'The quantity is less than 60' 
    WHEN UnitsInStock < 70 THEN 'The quantity is less than 70' 
    WHEN UnitsInStock < 80 THEN 'The quantity is less than 80' 
    WHEN UnitsInStock < 90 THEN 'The quantity is less than 90' 
    WHEN UnitsInStock < 100 THEN 'The quantity is less than 100' 
    WHEN UnitsInStock < 110 THEN 'The quantity is less than 110'   --Non compliant code
    WHEN UnitsInStock < 120 THEN 'The quantity is less than 120'   --Non compliant code
    ELSE 'The quantity is greater than or equal to 120'
END AS QuantityText
FROM Products
Visual Expert 2020
 VETSQLRULE37